chore: adapt ServiceProvider.close call not to pass any parameter anymore #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adapts the codebase to accommodate an API change in the @mongosh/service-provider-node-driver dependency where the close() method no longer accepts parameters.
- Removes the boolean parameter from
ServiceProvider.close()method call - Aligns with the updated interface in the upgraded dependency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
himanshusinghs
added
the
no-title-validation
kmruiz
approved these changes
Sep 4, 2025
|
We might not need this for now, I've reverted the latest update in #513. |
|
Closing this for now as we have reverted the package update on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the following PR we merged a bump to
@mongosh/service-provider-node-driverbut the bump came with an interface update toNodeDriverServiceProvider.close()(closedoes not support parameters anymore) so the usages in our code needed to be modified as well.This PR does the same fixing the build problem on main.
Checklist